Share MIN_NODE_BATCH_SIZE between the LP strategies

Co-authored-by: Florentin Dörre <[email protected]>

Author: breakanalysis

alpha/alpha-proc/src/main/java/org/neo4j/gds/ml/linkmodels/pipeline/predict/ApproximateLinkPrediction.java

@@ -39,7 +39,6 @@
 import java.util.stream.Stream;
 
 public class ApproximateLinkPrediction extends LinkPrediction {
-    static final int MIN_NODE_BATCH_SIZE = 10;
     private final KnnBaseConfig knnConfig;
 
     public ApproximateLinkPrediction(

alpha/alpha-proc/src/main/java/org/neo4j/gds/ml/linkmodels/pipeline/predict/ExhaustiveLinkPrediction.java

@@ -35,7 +35,6 @@
 import java.util.stream.LongStream;
 
 public class ExhaustiveLinkPrediction extends LinkPrediction {
-    private static final int MIN_NODE_BATCH_SIZE = 10;
     private final int topN;
     private final double threshold;
 

alpha/alpha-proc/src/main/java/org/neo4j/gds/ml/linkmodels/pipeline/predict/LinkPrediction.java

@@ -28,7 +28,7 @@
 import org.neo4j.gds.ml.linkmodels.pipeline.logisticRegression.LinkLogisticRegressionPredictor;
 
 public abstract class LinkPrediction extends Algorithm<LinkPrediction, LinkPredictionResult> {
-
+    static final int MIN_NODE_BATCH_SIZE = 10;
     private final LinkLogisticRegressionData modelData;
     private final LinkFeatureExtractor linkFeatureExtractor;
     private final Graph graph;

alpha/alpha-proc/src/main/java/org/neo4j/gds/ml/linkmodels/pipeline/predict/LinkPredictionPredictPipelineBaseConfig.java

@@ -116,7 +116,7 @@ default KnnBaseConfig approximateConfig() {
         var knnBuilder = ImmutableKnnBaseConfig.builder()
             .sampleRate(sampleRate())
             .nodeWeightProperty("NotUsedInLP")
-            .minBatchSize(ApproximateLinkPrediction.MIN_NODE_BATCH_SIZE)
+            .minBatchSize(LinkPrediction.MIN_NODE_BATCH_SIZE)
             .concurrency(concurrency());
 
         topK().ifPresent(knnBuilder::topK);