FastRP stream proc returns doubles

Author: jjaderberg

doc/asciidoc/algorithms/fastrp/fastrp.adoc

@@ -392,13 +392,13 @@ YIELD nodeId, embedding
 .Results
 |===
 | nodeId | embedding
-| 0      | [0.47740015, -0.66024077, -0.36686954, -1.7089111]
-| 1      | [0.798936, -0.49187183, -0.41281945, -1.6314402]
-| 2      | [0.47275326, -0.4958715, -0.33404678, -1.7141895]
-| 3      | [0.8290714, -0.32604763, -0.3317275, -1.437053]
-| 4      | [0.7749264, -0.47732472, 0.067513466, -1.5248264]
-| 5      | [0.8408374, -0.37151477, 0.12121138, -1.5309601]
-| 6      | [1.0, -0.11054421, -0.36979336, -0.92251444]
+| 0      | [0.47740015387535095, -0.6602407693862915, -0.3668695390224457, -1.7089110612869263]
+| 1      | [0.7989360094070435, -0.49187183380126953, -0.41281944513320923, -1.6314401626586914]
+| 2      | [0.47275325655937195, -0.49587151408195496, -0.33404678106307983, -1.7141895294189453]
+| 3      | [0.8290714025497437, -0.3260476291179657, -0.3317275047302246, -1.4370529651641846]
+| 4      | [0.7749264240264893, -0.4773247241973877, 0.06751346588134766, -1.5248264074325562]
+| 5      | [0.8408374190330505, -0.37151476740837097, 0.12121137976646423, -1.5309600830078125]
+| 6      | [1.0, -0.11054421216249466, -0.3697933554649353, -0.9225144386291504]
 |===
 --
 
@@ -532,13 +532,13 @@ YIELD nodeId, embedding
 .Results
 |===
 | nodeId | embedding
-| 0      | [0.10945529, -0.5032674, 0.46467367, -1.7539861]
-| 1      | [0.3639601, -0.39210302, 0.4627158, -1.8294234]
-| 2      | [0.123140976, -0.3213111, 0.40100977, -1.4710553]
-| 3      | [0.30704635, -0.24944797, 0.39478925, -1.34637]
-| 4      | [0.23112302, -0.30148715, 0.5848317, -1.2822187]
-| 5      | [0.14497177, -0.23121375, 0.5552002, -1.2605634]
-| 6      | [0.51391846, -0.079543315, 0.3690345, -0.91763735]
+| 0      | [0.10945528745651245, -0.5032674074172974, 0.4646736681461334, -1.753986120223999]
+| 1      | [0.3639600872993469, -0.39210301637649536, 0.4627158045768738, -1.829423427581787]
+| 2      | [0.12314097583293915, -0.3213110864162445, 0.40100976824760437, -1.471055269241333]
+| 3      | [0.3070463538169861, -0.24944797158241272, 0.3947892487049103, -1.346369981765747]
+| 4      | [0.23112301528453827, -0.30148714780807495, 0.584831714630127, -1.2822186946868896]
+| 5      | [0.14497177302837372, -0.2312137484550476, 0.5552002191543579, -1.2605633735656738]
+| 6      | [0.5139184594154358, -0.07954331487417221, 0.3690344989299774, -0.9176373481750488]
 |===
 --
 

proc/embeddings/src/main/java/org/neo4j/gds/embeddings/fastrp/FastRPStreamProc.java

@@ -92,19 +92,14 @@ protected AlgorithmFactory<FastRP, FastRPStreamConfig> algorithmFactory() {
     @SuppressWarnings("unused")
     public static final class StreamResult {
         public final long nodeId;
-        public final List<Number> embedding;
+        public final List<Double> embedding;
 
         StreamResult(long nodeId, float[] embedding) {
             this.nodeId = nodeId;
-            this.embedding = arrayToList(embedding);
-        }
-
-        static List<Number> arrayToList(float[] values) {
-            var floats = new ArrayList<Number>(values.length);
-            for (float value : values) {
-                floats.add(value);
+            this.embedding = new ArrayList<>(embedding.length);
+            for (var f : embedding) {
+                this.embedding.add((double) f);
             }
-            return floats;
         }
     }
 }

proc/embeddings/src/test/java/org/neo4j/gds/embeddings/fastrp/FastRPStreamProcTest.java

@@ -67,7 +67,7 @@ void shouldComputeNonZeroEmbeddings(List<Float> weights) {
         String query = queryBuilder.yields();
 
         runQueryWithRowConsumer(query, row -> {
-            List<Float> embeddings = (List<Float>) row.get("embedding");
+            List<Double> embeddings = (List<Double>) row.get("embedding");
             assertEquals(embeddingDimension, embeddings.size());
             assertFalse(embeddings.stream().allMatch(value -> value == 0.0));
         });
@@ -76,7 +76,7 @@ void shouldComputeNonZeroEmbeddings(List<Float> weights) {
     @Test
     void shouldComputeNonZeroEmbeddingsWhenFirstWeightIsZero() {
         int embeddingDimension = 128;
-        List<Float> weights = List.of(0.0f, 1.0f, 2.0f, 4.0f);
+        var weights = List.of(0.0D, 1.0D, 2.0D, 4.0D);
         GdsCypher.ParametersBuildStage queryBuilder = GdsCypher.call()
             .explicitCreation(FASTRP_GRAPH)
             .algo("fastRP")
@@ -88,7 +88,7 @@ void shouldComputeNonZeroEmbeddingsWhenFirstWeightIsZero() {
         String query = queryBuilder.yields();
 
         runQueryWithRowConsumer(query, row -> {
-            List<Float> embeddings = (List<Float>) row.get("embedding");
+            var embeddings = (List<Double>) row.get("embedding");
             assertFalse(embeddings.stream().allMatch(value -> value == 0.0));
         });
     }
@@ -107,10 +107,8 @@ void shouldComputeWithWeight() {
             .addParameter("relationshipWeightProperty", "weight")
             .yields();
 
-        List<List<Float>> embeddings = new ArrayList<>(3);
-        runQueryWithRowConsumer(query, row -> {
-            embeddings.add((List<Float>) row.get("embedding"));
-        });
+        List<List<Double>> embeddings = new ArrayList<>(3);
+        runQueryWithRowConsumer(query, row -> embeddings.add((List<Double>) row.get("embedding")));
 
         for (int i = 0; i < 128; i++) {
             assertEquals(embeddings.get(1).get(i), embeddings.get(2).get(i) * 2);