Use constant in RelationshipsBatchBuffer for elements per entity

Co-Authored-By: Max Kießling <[email protected]>

Author: s1ck

core/src/main/java/org/neo4j/gds/core/loading/RelationshipsBatchBuffer.java

@@ -29,6 +29,11 @@
 
 public final class RelationshipsBatchBuffer extends RecordsBatchBuffer<RelationshipReference> {
 
+    // For relationships, the buffer is divided into 2-long blocks
+    // for each relationship: source, target. Relationship and
+    // property references are stored individually.
+    public static final int ENTRIES_PER_RELATIONSHIP = 2;
+
     private final PartialIdMap idMap;
     private final int type;
     private final boolean throwOnUnMappedNodeIds;
@@ -55,9 +60,7 @@ public RelationshipsBatchBuffer(
         int capacity,
         boolean throwOnUnMappedNodeIds
     ) {
-        // For relationships: the buffer is divided into 4-long blocks
-        // for each rel: source, target, rel-id, prop-id
-        super(Math.multiplyExact(2, capacity));
+        super(Math.multiplyExact(ENTRIES_PER_RELATIONSHIP, capacity));
         this.idMap = idMap;
         this.type = type;
         this.throwOnUnMappedNodeIds = throwOnUnMappedNodeIds;

core/src/main/java/org/neo4j/gds/core/loading/ThreadLocalSingleTypeRelationshipImporter.java

@@ -183,7 +183,7 @@ public long importRelationships() {
             long[][] outProperties = propertyReader.readProperty(
                 sourceBuffer().relationshipReferences(),
                 sourceBuffer().propertyReferences(),
-                batchLength / 2,
+                batchLength / RelationshipsBatchBuffer.ENTRIES_PER_RELATIONSHIP,
                 targetBuffer().getPropertyKeyIds(),
                 targetBuffer().getDefaultValues(),
                 targetBuffer().getAggregations(),
@@ -195,7 +195,7 @@ public long importRelationships() {
             long[][] inProperties = propertyReader.readProperty(
                 sourceBuffer().relationshipReferences(),
                 sourceBuffer().propertyReferences(),
-                batchLength / 2,
+                batchLength / RelationshipsBatchBuffer.ENTRIES_PER_RELATIONSHIP,
                 targetBuffer().getPropertyKeyIds(),
                 targetBuffer().getDefaultValues(),
                 targetBuffer().getAggregations(),