Fix parameterization for generated estimate calls

Author: s1ck

examples/pregel-example/src/test/java/org/neo4j/gds/beta/pregel/cc/ConnectedComponentsPregelProcTest.java

@@ -135,8 +135,8 @@ void streamEstimate() {
         runQueryWithRowConsumer(query, r -> {
             assertEquals(10, r.getNumber("nodeCount").longValue());
             assertEquals(9, r.getNumber("relationshipCount").longValue());
-            assertEquals(296_232, r.getNumber("bytesMin").longValue());
-            assertEquals(296_232, r.getNumber("bytesMax").longValue());
+            assertEquals(299_912, r.getNumber("bytesMin").longValue());
+            assertEquals(299_912, r.getNumber("bytesMax").longValue());
         });
     }
 

examples/pregel-example/src/test/java/org/neo4j/gds/beta/pregel/pr/PageRankPregelProcTest.java

@@ -21,15 +21,16 @@
 
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
-import org.neo4j.gds.catalog.GraphCreateProc;
 import org.neo4j.gds.BaseProcTest;
 import org.neo4j.gds.GdsCypher;
+import org.neo4j.gds.catalog.GraphCreateProc;
 import org.neo4j.gds.extension.Neo4jGraph;
 
 import java.util.List;
 import java.util.Map;
 
 import static org.hamcrest.Matchers.closeTo;
+import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.neo4j.gds.beta.pregel.pr.PageRankPregel.PAGE_RANK;
 
 class PageRankPregelProcTest extends BaseProcTest {
@@ -101,6 +102,23 @@ void stream() {
         assertCypherResult(query + " RETURN nodeId, values.pagerank AS score", expected);
     }
 
+    @Test
+    void streamEstimate() {
+        var query = GdsCypher.call()
+            .loadEverything()
+            .algo("example", "pregel", "pr")
+            .streamEstimation()
+            .addParameter("maxIterations", 10)
+            .yields("bytesMin", "bytesMax", "nodeCount", "relationshipCount");
+
+        runQueryWithRowConsumer(query, r -> {
+            assertEquals(11, r.getNumber("nodeCount").longValue());
+            assertEquals(17, r.getNumber("relationshipCount").longValue());
+            assertEquals(296_280, r.getNumber("bytesMin").longValue());
+            assertEquals(296_280, r.getNumber("bytesMax").longValue());
+        });
+    }
+
     @Test
     void streamSeeded() {
         var createGraphQuery = GdsCypher.call()

pregel-proc-generator/src/main/java/org/neo4j/gds/beta/pregel/ProcedureGenerator.java

@@ -222,7 +222,10 @@ private MethodSpec algorithmFactoryMethod(ClassName algorithmClassName) {
                 .returns(MemoryEstimation.class)
                 .addParameter(pregelSpec.configTypeName(), "configuration")
                 .addStatement("var computation = new $T()", computationClassName(pregelSpec, ""))
-                .addStatement("return $T.memoryEstimation(computation.schema(configuration), computation.reducer().isPresent(), configuration.isAsynchronous())", Pregel.class)
+                .addStatement(
+                    "return $T.memoryEstimation(computation.schema(configuration), computation.reducer().isEmpty(), configuration.isAsynchronous())",
+                    Pregel.class
+                )
                 .build()
             )
             .build();

pregel-proc-generator/src/test/resources/expected/ComputationMutateProc.java

@@ -103,7 +103,7 @@ public Task progressTask(Graph graph, PregelProcedureConfig configuration) {
             @Override
             public MemoryEstimation memoryEstimation(PregelProcedureConfig configuration) {
                 var computation = new Computation();
-                return Pregel.memoryEstimation(computation.schema(configuration), computation.reducer().isPresent(), configuration.isAsynchronous());
+                return Pregel.memoryEstimation(computation.schema(configuration), computation.reducer().isEmpty(), configuration.isAsynchronous());
             }
         };
     }

pregel-proc-generator/src/test/resources/expected/ComputationStatsProc.java

@@ -103,7 +103,7 @@ public Task progressTask(Graph graph, PregelProcedureConfig configuration) {
             @Override
             public MemoryEstimation memoryEstimation(PregelProcedureConfig configuration) {
                 var computation = new Computation();
-                return Pregel.memoryEstimation(computation.schema(configuration), computation.reducer().isPresent(), configuration.isAsynchronous());
+                return Pregel.memoryEstimation(computation.schema(configuration), computation.reducer().isEmpty(), configuration.isAsynchronous());
             }
         };
     }

pregel-proc-generator/src/test/resources/expected/ComputationStreamProc.java

@@ -99,7 +99,7 @@ public Task progressTask(Graph graph, PregelProcedureConfig configuration) {
             @Override
             public MemoryEstimation memoryEstimation(PregelProcedureConfig configuration) {
                 var computation = new Computation();
-                return Pregel.memoryEstimation(computation.schema(configuration), computation.reducer().isPresent(), configuration.isAsynchronous());
+                return Pregel.memoryEstimation(computation.schema(configuration), computation.reducer().isEmpty(), configuration.isAsynchronous());
             }
         };
     }

pregel-proc-generator/src/test/resources/expected/ComputationWriteProc.java

@@ -103,7 +103,7 @@ public Task progressTask(Graph graph, PregelProcedureConfig configuration) {
             @Override
             public MemoryEstimation memoryEstimation(PregelProcedureConfig configuration) {
                 var computation = new Computation();
-                return Pregel.memoryEstimation(computation.schema(configuration), computation.reducer().isPresent(), configuration.isAsynchronous());
+                return Pregel.memoryEstimation(computation.schema(configuration), computation.reducer().isEmpty(), configuration.isAsynchronous());
             }
         };
     }