Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please add correct typing #37

Open
ChristianEbeling opened this issue Aug 21, 2024 · 1 comment · May be fixed by #39
Open

Please add correct typing #37

ChristianEbeling opened this issue Aug 21, 2024 · 1 comment · May be fixed by #39

Comments

@ChristianEbeling
Copy link

In https://github.com/neo4j-labs/rdflib-neo4j/blob/master/rdflib_neo4j/Neo4jStore.py?plain=1#L21

Please change

def __init__(self, config: Neo4jStoreConfig, neo4j_driver: Driver = None):

to

def __init__(self, config: Neo4jStoreConfig, neo4j_driver: Driver | None = None):
nmervaillie added a commit to nmervaillie/rdflib-neo4j that referenced this issue Aug 29, 2024
@nmervaillie
Fix type hint issue in store init
7bb4b43 
Make it explicit that None is an acceptable value

Fixes neo4j-labs#37
@nmervaillie nmervaillie linked a pull request Aug 29, 2024 that will close this issue
Open
@nmervaillie
Copy link
Collaborator

Good point, thanks for raising this @ChristianEbeling

@alfredorubin96 alfredorubin96 linked a pull request Sep 16, 2024 that will close this issue
Fix type hint issue in store init #39
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix type hint issue in store init nmervaillie/rdflib-neo4j
2 participants
@nmervaillie @ChristianEbeling