Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HAS_NXSDK can be false even when nxsdk is installed #253

Open
hunse opened this issue Oct 16, 2019 · 1 comment
Open

HAS_NXSDK can be false even when nxsdk is installed #253

hunse opened this issue Oct 16, 2019 · 1 comment

Comments

@hunse
Copy link
Collaborator

hunse commented Oct 16, 2019

I think the main way for this to happen is if our snip_maker import fails.

We should move the snip_maker import into the if HAS_NXSDK block below where we do other sub-imports within nxsdk. We can wrap it in its own try block there if we want (to just not do the snip_maker monkeypatch if its not there), or just fail completely, but at least then it would be clear why things aren't working.
@hunse
Copy link
Collaborator Author

hunse commented Oct 29, 2019

I think I encountered this when using an inappropriate NxSDK version, which didn't have snip_maker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hunse