-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sqlDataTypeCase
and sqlFunctionCase
options?
#13
Comments
Yeah. It's definitely much simpler to achieve in here. |
Also worth considering are the capitalization rules in SQLFluff. It implements 5 categories:
It might be good to align our implementation with that. Though on the other hand I'd like to avoid configuration options and keep this plugin opinionated... but capitalization is an area where I've already decided that it's better for it to be configurable. This still leaves the question of picking the best defaults.
|
Sounds reasonable to me 👍 Data types defaulting to uppercase is probably a good default too - the PostgreSQL docs seem like an outlier when it comes to their usage of lowercase data types |
Similar to the
dataTypeCase
andfunctionCase
insql-formatter
:dataTypeCase
andfunctionCase
options sql-formatter-org/sql-formatter#673It seems like this would be much simpler to implement here, because according to SQL Explorer the node types already exist:
The text was updated successfully, but these errors were encountered: