31 update transfer to use checkbalance #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t. Updated Maven dependencies. Ignore errors on run, caused by tests not being finished but works as normal
…, will look for loop
…gorithm-implementation-project into 16-abstraction-and-separation-of-logic
Merging w main to keep track of changes while writing tests
|
Solve merge conflict with main and look at error message sent on discord |
…emisis84/Istanbul-BFT-Consensus-Algorithm-implementation-project into 31-update-transfer-to-use-checkbalance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added checkBalance before transfer for all nodes. Adds overhead, but ensure that nodes that have been disconnected from the network are able to catch up, instead of never participating in consensus because the registered wallet amount is too little.