Version 46 (legacy GNOME 44) #203
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix completely broken Turkish translation
mercutiodesign
suggested changes
Jun 10, 2023
utils.js
Outdated
Comment on lines
196
to
209
| let filtered = []; | ||
| image_list.forEach(function(x, i) { | ||
| let ignore = false; | ||
| if (filter.faves && !x.favourite) | ||
| ignore = true; | ||
| if (filter.min_height && x.height < filter.min_height) | ||
| ignore = true; | ||
| if (filter.hidden && x.hidden) | ||
| ignore = true; | ||
|
|
||
| if (!ignore) | ||
| filtered.push(x); | ||
| }); | ||
| return filtered; |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Yeah there is a bit of refactoring I need to do for the awkward logic that's kind of been hacked together over time. This one is a new hack though, haha.
There was a problem hiding this comment.
Done, thanks for review @mercutiodesign
mercutiodesign
approved these changes
Jun 22, 2023
This was
linked to
issues
Jun 26, 2023
Closed
Closed
This was referenced Oct 21, 2023
Merged
typo: Gnome -> GNOME
Update Korean translation
Fix spelling mistakes and set french apostrophe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this release: