Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention non-collaborators instead of requesting review from them and fail #98

Open
Qrox opened this issue May 25, 2023 · 3 comments · May be fixed by #99
Open

Mention non-collaborators instead of requesting review from them and fail #98

Qrox opened this issue May 25, 2023 · 3 comments · May be fixed by #99

Comments

@Qrox
Copy link

Qrox commented May 25, 2023 •
edited
Loading

Hello, I'm trying to use this action in one of the repos that I contribute to, but it seems you can only request review from collaborators, see this test action. Since our repo has many contributors, giving collaborator rights to each of them who is willing or wish to review is not really feasible.

I'm thinking perhaps this action can be extended to write a comment to mention the people that cannot be requested for review because they don't have collaborator rights. I searched for other actions and the closest thing I was able to find that has something similar to what I want to do is this action, which seems to be not longer maintained and only supports mentioning according to labels, so I think this action is closest to what I want.
@necojackarc
Copy link
Owner

@Qrox It looks like a permission issue to me. I think you should check two things:

  • Can you manually request those for a review? If not, the permission to do so is missing in the first place.
  • If you can do so manually but you can't do it with GitHub Actions, can you check if your GitHub token has sufficient permission to perform this?

@Qrox
Copy link
Author

Qrox commented May 27, 2023

It seems I cannot manually request non-collaborators for review, so yes you probably don't have permission to request review from non-collaborators in the first place. It also says so in the docs that it returns http 422 status "if user is not a collaborator".

I was using the GITHUB_TOKEN token and gave write permissions to it in the settings.

@Qrox Qrox linked a pull request Jun 8, 2023 that will close this issue
Open
@rushi
Copy link

rushi commented Jun 13, 2023

A general note for anyone else who gets this error - I ran into this issue with a Github team. It turns out my team was 'secret', making it visible solved the problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Request review from non-collaborators by mentioning them Qrox/auto-request-review
3 participants
@rushi @necojackarc @Qrox