Incorrect mutation to options object

[vjrngn]

Hey folks 👋🏼

I recently updated the package to 1.2.0 and looks like there's a bug that was introduced (link below)
https://github.com/nearform/fastify-auth0-verify/blob/master/index.js#L15C28-L15C28

My application sets the options.domain property but it is being deleted which is causing an bad behaviour.
Ideally, you would create a copy of the options object and leave user options untouched.

Didn't send a PR since this is a single line change. Happy to send a PR if that helps

Proposal:

function fastifyAuth0Verify(instance, options, done) {
  try {
    const optionsCopy = { ...options };
    let { domain, secret } = optionsCopy;

    if (domain) {
      delete optionsCopy.domain
   }
...
}

[simoneb]

Thanks for catching this. What kind of bad behavior is the deletion of the domain property causing?

[simoneb]

Closing for lack of response from the OP

[vjrngn]

Apologies for not getting back quick enough. We are using the options object in other part of our application - so passing it around on service start. This mutation caused a bug in a dependent service.

[simoneb]

Can you send a PR please? I'll reopen the issue

[vjrngn]

Sure thing! Travelling at the moment and don't have access to a computer. Will raise one after I'm back home :)

[ilteoood]

@vjrngn are you still going to submit a PR?
Otherwise, after 11 months, probably we can close this.