Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review PR #887 (add function access keys to additional contracts by using multiple key stores) #920

Closed
trechriron opened this issue Sep 13, 2023 · 0 comments
Labels
Emerging Tech Emerging Tech flying formation at Pagoda

Comments

@trechriron
Copy link
Collaborator

Description

This is to review PR: wallet-selector: add function access keys to additional contracts by using multiple key stores

Kujtim Prenku
August 21, 2023 at 4:34 AM

Hi, @daryl Collins we need your input on this PR since it’s adding a new function/method to the API of the wallet selector so we wanted to check with you.

This PR adds a new function addContractConnection which creates a new wallet connection (with a new prefix) through NAJ and adds a key by signing a transaction with the addKey action.
What they are attempting to do with this new function is to add support for multiple contracts.

This PR is related to the signInMulti but the approach is very different:
#887

We left a comment in the signInMulti PR too:
#811 (comment)

@trechriron trechriron added Emerging Tech Emerging Tech flying formation at Pagoda Near BOS labels Sep 13, 2023
@AmmarHumackicSQA AmmarHumackicSQA closed this as not planned Won't fix, can't repro, duplicate, stale Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Emerging Tech Emerging Tech flying formation at Pagoda
Projects
None yet
Development

No branches or pull requests

2 participants