Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make account as optional param for SignInParams and SignInMultiParams #918

Open
1 task
Tracked by #917
trechriron opened this issue Sep 13, 2023 · 1 comment
Open
1 task
Tracked by #917
Assignees
Labels
Emerging Tech Emerging Tech flying formation at Pagoda

Comments

@trechriron
Copy link
Collaborator

trechriron commented Sep 13, 2023

Description

Make account optional for SignInParams and SignInMultiParams on Injected Wallets

Kujtim Prenku
May 25, 2023 at 1:47 AM

@daryl Collins, we created a PR in the NEPs for Injected Wallets based on the call we had and based on the comment left on the ticket for adding signInMulti: SQC-540: NEP-428 Wallet Selector Interface
PAGODA REVIEW

Related Issues

  1. 0 of 1
    Emerging Tech
    kujtimprenkuSQA
@trechriron trechriron added Emerging Tech Emerging Tech flying formation at Pagoda Near BOS Epic Milestone or collection of like issues labels Sep 13, 2023
@trechriron trechriron removed the Epic Milestone or collection of like issues label Sep 13, 2023
@kujtimprenkuSQA
Copy link
Contributor

Based on the latest discussions we've had in the last meeting related to this issue it was mentioned that the change looked fine for Daryl and he informed us that he had a talk with Andy who is a reviewer of the PR and explained that the PR in the NEP is good to be approved and merged, after that we've not had any more discussions about this change, it was left for a comment to be added on the PR for visibility with the context why this change should be merged.

@github-project-automation github-project-automation bot moved this to Backlog 🥶 in DevRel Jun 3, 2024
@thisisjoshford thisisjoshford removed this from DevRel Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Emerging Tech Emerging Tech flying formation at Pagoda
Projects
None yet
Development

No branches or pull requests

3 participants