fix: exceed prepaid gas in nft_approve #1109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frol
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When user use implicit account to sign tx, more gas will be used, it will cause that 10Tgas is not enough for
nft_approve.This is an example:
https://legacy.explorer.near.org/transactions/CwuFtBWYnr5xkdpvbbTtznvFUf1FneAwMVBpPi8Q8wyd
User can not list NameSky NFT in marketplace with implicit account as signer
I think we can remove static gas for x-call
nft_on_approvebecause default gas weight 1 will distribute remaining gas to it.