Skip to content
This repository has been archived by the owner on Oct 4, 2024. It is now read-only.

Create a command to generate pub/private keypair for pool with the right field name #955

Open
janewang opened this issue Mar 28, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request T-dev-tools

Comments

@janewang
Copy link

janewang commented Mar 28, 2022

Today, validators use to near generate-key <pool_id> to create a pub/private key for their

This creates a JSON file containing:


{ "account_id": "account_id", "public_key": "ed25519:HeaBJ3xLgvZacQWmEctTeUqyfSU4SDEnEwckWxd92W2G", "private_key": "ed25519:****" } 

At this point, the validator has to manually change field name “private_key” to “secret_key”, which is suboptimal.

Is your feature request related to a problem? Please describe.
I suggest we create a new command
near generate-pool-key <pool_id> that would create the file:


{ "account_id": "account_id", "public_key": "ed25519:HeaBJ3xLgvZacQWmEctTeUqyfSU4SDEnEwckWxd92W2G", "secret_key": "ed25519:****" } 

Additional context
This is important during validator onboarding to avoid unnecessary and manual key file editing.

@janewang janewang added the enhancement New feature or request label Mar 28, 2022
@willemneal
Copy link
Contributor

Our of curiosity, why is there a difference in the name of the field? Should we perhaps address this with a better key standard?

(though clearly use this as temporary measure)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request T-dev-tools
Projects
None yet
Development

No branches or pull requests

3 participants