Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new arg base64file to support loading base64 blob from file int… #938

Closed
wants to merge 3 commits into from

Conversation

TrevorJTClarke
Copy link

…o CLI args

This PR fixes #937
Directly impacting any CLI args on linux

commands/call.js Outdated
parsedArgs = Buffer.from(fileargs, 'base64');
console.log(`Loaded base64 args file, size ${parsedArgs.length}`);
} catch (e) {
console.log('Could not load base64 file!');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this throw so as exit? Currently all errors throw and you end up with a large noisy help message, but there are plans to refactor how errors are handled.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, changed!

@TrevorJTClarke
Copy link
Author

@willemneal looks like the last build failed because RPC 502: https://app.travis-ci.com/github/near/near-cli/builds/246520845#L260

@TrevorJTClarke
Copy link
Author

@willemneal looks like the last build failed because RPC 502: https://app.travis-ci.com/github/near/near-cli/builds/246520845#L260

@willemneal should i trigger with a commit, or can you manually trigger a rebuild? I think RPC services shipped recently are fixed now.

@willemneal
Copy link
Contributor

@TrevorJTClarke I wish I could, but I'm not a collaborator. So you could maybe do a push again or a small change and push, then revert and force push?

@TrevorJTClarke
Copy link
Author

@willemneal nevermind, same RPC 502... Some config or something got changed. No idea how to help get this across the line. Super needed in timely manner - Auditors starting in 8 days need this

@willemneal
Copy link
Contributor

@TrevorJTClarke You can depend on your version of near-cli. npm install ...

I had to do that while waiting for this PR: #903, which has been released and could also be used to solve your issue.

@gagdiez
Copy link
Contributor

gagdiez commented Jan 23, 2024

This has been stalled for more than 2 years, I will proceed to close it and we can re-open it if the community requires it.

With that being said, I think it is quite simple to do this in the command line, we actually show how to do it when relevant in our docs: https://docs.near.org/tutorials/examples/factory#update-the-stored-contract

@gagdiez gagdiez closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support base64 encoded files as arguments (fixes linux ulimit issues)
3 participants