Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEAR CLI is shown as "Unknown App" during the login #1011

Open
volovyks opened this issue Aug 10, 2022 · 0 comments
Open

NEAR CLI is shown as "Unknown App" during the login #1011

volovyks opened this issue Aug 10, 2022 · 0 comments
Labels
bug Something isn't working P1 High priority security Pull requests that address a security vulnerability

Comments

@volovyks
Copy link
Collaborator

Screenshot 2022-08-10 at 14 32 26

Wallet made a breaking change and now accepts the referer parameter in the header instead of a URL parameter.
As @MaximusHaximus said, it was done to prevent phishing attacks.

The current design does not allow us to add this parameter as a header, because we are constructing the URL and opening it in the browser.

Related logic: https://github.com/near/near-cli/blob/master/index.js#L123

cc @frol it is broken in RUST CLI as well.

@volovyks volovyks added bug Something isn't working P1 High priority security Pull requests that address a security vulnerability labels Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P1 High priority security Pull requests that address a security vulnerability
Projects
None yet
Development

No branches or pull requests

1 participant