Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is_stable is true for nodes with lagging block heights #871

Closed
ppca opened this issue Oct 3, 2024 · 2 comments · Fixed by #887
Closed

is_stable is true for nodes with lagging block heights #871

ppca opened this issue Oct 3, 2024 · 2 comments · Fixed by #887
Labels
Emerging Tech Emerging Tech flying formation at Pagoda Near BOS NEAR BOS team at Pagoda

Comments

@ppca
Copy link
Contributor

ppca commented Oct 3, 2024

If a node starts at a very early block height and has been syncing but is still way behind, is_stable will still show true

@ppca ppca added Near BOS NEAR BOS team at Pagoda Emerging Tech Emerging Tech flying formation at Pagoda labels Oct 3, 2024
@ppca
Copy link
Contributor Author

ppca commented Oct 3, 2024

Nodes could publish their current block height in their state, i.e. {url}/state, and nodes can query each other for block heights, and they'd know whether each other are behind or not

@ppca
Copy link
Contributor Author

ppca commented Oct 4, 2024

Could query it from RPC endpoint too, and parse it from the json response. Then the node does not need to query other nodes, it knows how delayed it is and can publish is_stable based on comparison of its height v.s. rpc endpoint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Emerging Tech Emerging Tech flying formation at Pagoda Near BOS NEAR BOS team at Pagoda
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant