fix: use dunce crate to remove UNC prefix
#110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iho
changed the title
dunce crate to remove UNC prefix
frol
reviewed
Oct 11, 2023
Co-authored-by: Vlad Frolov <[email protected]>
frol
requested changes
Oct 11, 2023
frol
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4
On Windows,
Path::canonicalize()returns a path with the UNC prefix not supported bycmd.exeand breaks the compilation of all crates that haveinclude!macros in it. The problem is well known, and no proper solution at the current moment rust-lang/rust#42869For now, I just cut this UNC prefix, but if users complain about that, we can come out with a more sophisticated solution like https://lib.rs/crates/dunce