Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approach for 'none' #382

Open
aclayton555 opened this issue Apr 15, 2024 · 2 comments
Open

Approach for 'none' #382

aclayton555 opened this issue Apr 15, 2024 · 2 comments
Labels

Comments

@aclayton555
Copy link
Contributor

This issue follows this service desk ticket: https://sagebionetworks.jira.com/browse/HTAN-409

Following initial investigation and consultation with FAIR, Amy notes, "we talked about this issue in the greater context of using “none” and the consensus is that we should avoid using none as a string in general. We have some ideas on how we can better handle this, but can we consider avoiding it for the next HTAN iteration?

As of April 2024, Adam notes, "We currently have 17 occurrences of none (case insensitive) in our data model."

This issue to track two actions (may be split into sep tickets):

  1. engage with FAIR on strategy and approach for none types
  2. evaluate use-of and remove use of none in the HTAN data model
  3. Based on outcomes of 1 and 2, remove use of none in the HTAN data model

My impression is that 1 and 2 can be conducted in parallel, and will confirm how exactly we proceed with 3.

@aclayton555
Copy link
Contributor Author

Consider this for 24-5 sprint and determine what needs to be done now to alleviate any blockers for contributors vs longer term fixes in renewal.

See also Adam's latest comments in this similar Jira ticket: https://sagebionetworks.jira.com/browse/HTAN-401

@adamjtaylor
Copy link
Contributor

This is also an issue in HTAN-469.

I'm going to make a PR to add unfixed as an attribute for Fixative type to unblock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants