-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for pipeline events #27
Comments
Actually, we're about to dig into GitLab CI soon, at work. I will definitely need to make some modifications for that, and will also fix some more of these pending bugs and vulnerable packages. |
I was able to reorganize my 10% time at work 🎉, which will give me more time to work on this, periodically. I just released 2.1.0 which resolved 5 of the pending issues and brings the package dependencies and the code up to date. Pipeline events are next! |
@genru I noticed that you have a fork with some work done for the pipeline and build events. When I go to implement those here, may I use your code either directly or as a reference? |
@nazrhyn sure, please. but have no any guarantee |
need i make a pull request? |
@genru Whatever you prefer. I am happy to simply use it as reference, especially if you think there may be improvements to be made. |
@genru @yegorski I'm starting this and was interested to hear your thoughts about something: When would you want to see notifications for individual jobs/builds within a pipeline? Wouldn't that be pretty spammy? If a pipeline fails, then the builds list can be looked at to determine which job/build has failed, and then that can be sent to Slack, but actually showing every single job/build seems like overkill. |
@nazrhyn Yes, pipeline hooks everything. it is a bit too many events. I thought only notify key pipeline events would be nice. I dont understand what do you mean "the builds list can be looked at to determine which job/build has failed". I use |
Your first response is kind of what I was looking for. We'll see how it goes! |
Do you plan to listen for "Pipeline events"?
One thing I can see being useful is custom notifications on important events, such as
master
build failing, etc, where the Slack integration would do an@here
to the channel.The text was updated successfully, but these errors were encountered: