Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for pipeline events #27

Open
yegorski opened this issue Nov 19, 2018 · 10 comments
Open

Support for pipeline events #27

yegorski opened this issue Nov 19, 2018 · 10 comments
Assignees

Comments

@yegorski
Copy link

Do you plan to listen for "Pipeline events"?

One thing I can see being useful is custom notifications on important events, such as master build failing, etc, where the Slack integration would do an @here to the channel.

@nazrhyn
Copy link
Owner

nazrhyn commented Nov 19, 2018

Actually, we're about to dig into GitLab CI soon, at work. I will definitely need to make some modifications for that, and will also fix some more of these pending bugs and vulnerable packages.

@nazrhyn nazrhyn self-assigned this Mar 27, 2019
@nazrhyn
Copy link
Owner

nazrhyn commented Mar 29, 2019

I was able to reorganize my 10% time at work 🎉, which will give me more time to work on this, periodically. I just released 2.1.0 which resolved 5 of the pending issues and brings the package dependencies and the code up to date.

Pipeline events are next!

@nazrhyn
Copy link
Owner

nazrhyn commented Mar 29, 2019

@genru I noticed that you have a fork with some work done for the pipeline and build events. When I go to implement those here, may I use your code either directly or as a reference?

@genru
Copy link

genru commented Apr 1, 2019

@nazrhyn sure, please. but have no any guarantee

@genru
Copy link

genru commented Apr 1, 2019

need i make a pull request?

@nazrhyn
Copy link
Owner

nazrhyn commented Apr 1, 2019

@genru Whatever you prefer. I am happy to simply use it as reference, especially if you think there may be improvements to be made.

@genru
Copy link

genru commented Apr 2, 2019

@nazrhyn #29

@nazrhyn
Copy link
Owner

nazrhyn commented May 10, 2019

@genru @yegorski I'm starting this and was interested to hear your thoughts about something:

When would you want to see notifications for individual jobs/builds within a pipeline? Wouldn't that be pretty spammy?

If a pipeline fails, then the builds list can be looked at to determine which job/build has failed, and then that can be sent to Slack, but actually showing every single job/build seems like overkill.

@genru
Copy link

genru commented May 11, 2019

@nazrhyn Yes, pipeline hooks everything. it is a bit too many events. I thought only notify key pipeline events would be nice.

I dont understand what do you mean "the builds list can be looked at to determine which job/build has failed". I use .gitlab-ci.yaml do my CI work, In my scenario, when a job failed just has one message pipeline xxxx by xxx failed comes in.

@nazrhyn
Copy link
Owner

nazrhyn commented May 13, 2019

Your first response is kind of what I was looking for. We'll see how it goes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants