Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retningslinjen for CODEOWNERS bør endres pga epost spam fra Github #4

Open
ahusby opened this issue Nov 21, 2019 · 1 comment · May be fixed by #6
Open

Retningslinjen for CODEOWNERS bør endres pga epost spam fra Github #4

ahusby opened this issue Nov 21, 2019 · 1 comment · May be fixed by #6

Comments

@ahusby
Copy link
Contributor

ahusby commented Nov 21, 2019

Ref. https://github.com/navikt/offentlig/blob/master/guider/nye-repo.md#codeowners

En konsekvens av å bruke teamnavnet i CODEOWNERS er at teamet automatisk blir assignet til pull requests, som fører til at alle på teamet blir spammet med epost fra alle hendelser på alle pullrequester på alle repos som bruker CODEOWNERS slik. Det tror jeg de færreste ønsker. Se https://stackoverflow.com/c/nav-it/questions/516/519

Foreslår at denne retnignslinjen endres til å opplyse pom denne konsekvensen, si at dette er frivillig og ev. angir alternativer.
@ahusby
Copy link
Contributor Author

ahusby commented Nov 21, 2019

Diskusjon på Slack: https://nav-it.slack.com/archives/C6NGMTSTA/p1574340077065000

@Starefossen Starefossen linked a pull request Sep 11, 2023 that will close this issue
Si at CODEOWNERS er frivillig pga epost-spam #6
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Si at CODEOWNERS er frivillig pga epost-spam ahusby/offentlig
1 participant
@ahusby