base64 should be a pointer to allow empty blobs

Signed-off-by: Alexis Guerville <[email protected]>

Author: Sadzeih

libsql/internal/hrana/value.go

@@ -11,12 +11,15 @@ import (
 type Value struct {
 	Type   string `json:"type"`
 	Value  any    `json:"value,omitempty"`
-	Base64 string `json:"base64,omitempty"`
+	Base64 *string `json:"base64,omitempty"`
 }
 
 func (v Value) ToValue(columnType *string) any {
 	if v.Type == "blob" {
-		bytes, err := base64.StdEncoding.WithPadding(base64.NoPadding).DecodeString(v.Base64)
+		if v.Base64 == nil {
+			return nil
+		}
+		bytes, err := base64.StdEncoding.WithPadding(base64.NoPadding).DecodeString(*v.Base64)
 		if err != nil {
 			return nil
 		}
@@ -65,7 +68,8 @@ func ToValue(v any) (Value, error) {
 		res.Value = text
 	} else if blob, ok := v.([]byte); ok {
 		res.Type = "blob"
-		res.Base64 = base64.StdEncoding.WithPadding(base64.NoPadding).EncodeToString(blob)
+		b64 := base64.StdEncoding.WithPadding(base64.NoPadding).EncodeToString(blob)
+		res.Base64 = &b64
 	} else if float, ok := v.(float64); ok {
 		res.Type = "float"
 		res.Value = float

libsql/internal/hrana/value_test.go

@@ -7,6 +7,10 @@ import (
 	"testing"
 	"time"
 )
+	
+func toPtr[T any](v T) *T {
+	return &v
+}
 
 func TestValueToValue(t *testing.T) {
 	tests := []struct {
@@ -43,10 +47,18 @@ func TestValueToValue(t *testing.T) {
 			name: "bytes",
 			value: Value{
 				Type:   "blob",
-				Base64: "YmFy",
+				Base64: toPtr("YmFy"),
 			},
 			want: []byte("bar"),
 		},
+		{
+			name: "bytes",
+			value: Value{
+				Type:   "blob",
+				Base64: toPtr(""),
+			},
+			want: []byte{},
+		},
 		{
 			name: "float",
 			value: Value{
@@ -111,10 +123,10 @@ func TestToValue(t *testing.T) {
 		},
 		{
 			name:  "bytes",
-			value: []byte("bar"),
+			value: []byte{},
 			want: Value{
 				Type:   "blob",
-				Base64: "YmFy",
+				Base64: toPtr(""),
 			},
 		},
 		{
@@ -195,7 +207,7 @@ func TestMarshal(t *testing.T) {
 			name: "bytes",
 			value: Value{
 				Type:   "blob",
-				Base64: "YmFy",
+				Base64: toPtr("YmFy"),
 			},
 			marshaled: `{"type":"blob","base64":"YmFy"}`,
 		},
@@ -263,7 +275,7 @@ func TestUnmarshal(t *testing.T) {
 			name: "bytes",
 			value: Value{
 				Type:   "blob",
-				Base64: "YmFy",
+				Base64: toPtr("YmFy"),
 			},
 			marshaled: `{"type":"blob","base64":"YmFy"}`,
 		},