Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github base-url validation is failing for company internal enterprise github address #964

Open
jordao76 opened this issue Apr 14, 2023 · 0 comments

Comments

@jordao76
Copy link

jordao76 commented Apr 14, 2023

Hello, while configuring a github base-url in the .gitconfig.yml file I'm getting an error from the controller UI:

Field 'base-url' doesn't conform to url format.
Please check your .gitconfig.yml

The config I'm using is for my company's internal enterprise github address, similar to this:

base-url: https://github.mycompany.corp/api/v3

Note that corp is an internal domain for my company, and not a top-level domain (ref: https://data.iana.org/TLD/tlds-alpha-by-domain.txt)

Code where the error happens:

Please check this and perhaps make the validation more lenient. I'm not sure this would help:

https://commons.apache.org/proper/commons-validator/apidocs/org/apache/commons/validator/routines/UrlValidator.html#ALLOW_LOCAL_URLS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant