Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site title incorrectly pulled when submitting to Reddit #18

Open
3 tasks
IfaqYurmama opened this issue Apr 11, 2018 · 2 comments
Open
3 tasks

Site title incorrectly pulled when submitting to Reddit #18

IfaqYurmama opened this issue Apr 11, 2018 · 2 comments
Labels
bounty-medium bug Something isn't working

Comments

@IfaqYurmama
Copy link
Collaborator

IfaqYurmama commented Apr 11, 2018

Description

The meta information should pull through from each page correctly

image

Usually it should pull the site title that's also displayed in the tab (
image)

Motivation

To have correctly displaying open graph data across the whole site.

Acceptance Criteria

  • Every page on the site should have unique open graph data
  • The open graph data should display when posting the link to social media
  • Title, image, description at least.

Dependencies

Not exactly dependent but there is similar work going on in #185 so either wait to see that solution and implement it site wide or do this one first.

@matt-auckland
Copy link
Member

The info that gets pulled by reddit is stored in the header of each page, but with the current set up I'm not sure if we can modify the header per news post as the header is a sibling partial of the content. @red010b37 @craigmacgregor Can you confirm this?

Where the info is pulled from: https://github.com/NAVCoin/nav-community-site/blob/master/themes/nav-community-v1/layouts/partials/head.html

@zanuka
Copy link
Contributor

zanuka commented May 23, 2018

@matt-auckland @IfaqYurmama @red010b37 @craigmacgregor yeah this can be fixed by creating a partial template for meta elements so things like title, twitter description, share image can be set on a per post basis. Right now it's all being set globally in head.html. good catch!

@proletesseract proletesseract added the bug Something isn't working label Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty-medium bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants