Fix/matching by col numeric #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jefferis
commented
Aug 16, 2022
jefferis
commented
- Fixes fix bug in matching by first column #503
- but we still need to sort out numeric ids like 1e5, since:
* closes #503 * but still doesn't deal with the bug when id=1e5
Codecov Report
@@ Coverage Diff @@
## master #504 +/- ##
==========================================
+ Coverage 75.73% 76.88% +1.14%
==========================================
Files 48 48
Lines 5906 5914 +8
==========================================
+ Hits 4473 4547 +74
+ Misses 1433 1367 -66
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Doesn't |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.