Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a 'registry' of neurons #138

Open
jdmanton opened this issue Jul 1, 2014 · 5 comments
Open

Implement a 'registry' of neurons #138

jdmanton opened this issue Jul 1, 2014 · 5 comments
Milestone

Comments

@jdmanton
Copy link
Collaborator

jdmanton commented Jul 1, 2014

It would be useful to have some form of 'registry' where sets of neurons originating from the same dataset could be listed. This would allow a user to refer to a neuron by character vector, such as "DvGlutMARCM-F002528_seg001", while still allowing the requisite functions to know that this neuron corresponds to data from FlyCircuit. This would generalise the behaviour of the flycircuit package (and e.g. plot3dfc/pop3dfc) to handle multiple data sources.

Some form of prefix/suffix attached to the character vectors might be useful, especially when combining neurons from multiple datasets.

@jefferis
Copy link
Collaborator

jefferis commented Jul 3, 2014

Something like:

#' @param x A neuronlist whose names will be registered as canonical identifiers for these neurons.
#' @param moreids A named character vector that maps additional identifiers 
#'   onto canonical identifiers. Perhaps also a function that can be applied to names(x)
#' @param prefix A character vector specifying a prefix to add to the identifier. 
#'   Defaults to name of x. (see details).
#' @param sep A character vector specifying a separator between prefix and identifier.
#'   Defaults to ":" name of x.
register.neuronlist<-function(x, moreids=NULL, prefix=NULL, sep=":")

views @ajdm?

@jefferis
Copy link
Collaborator

jefferis commented Jul 3, 2014

Of course register still seems like a less than ideal name for the generic given how much image registration we do ...

@jdmanton
Copy link
Collaborator Author

jdmanton commented Jul 3, 2014

Looks good to me. Perhaps deposit as an alternative to register?

@jefferis
Copy link
Collaborator

jefferis commented Jul 5, 2014

Looks good to me. Perhaps deposit as an alternative to register?

I wonder if deposit has the suggestion of putting the neurons into a location rather than telling someone about them.

@jefferis
Copy link
Collaborator

jefferis commented Jul 5, 2014

The main change besides adding the register/deposit function would be to update plot3d.character to use it. Possibly there should be a separate function that fetches neurons by identifier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants