Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix space issue in image tags #4014

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

dbolack-ab
Copy link
Collaborator

Description

Alter varCallInline content to align with preceding varDefBlock in inline definitions.

This was failing due to both labels having the extraneous spaces cleaned up but the variable label portion of the varCallInline did not, preventing them from being matched during variable resolution.

Related Issues or Discussions

QA Instructions, Screenshots, Recordings

Bug with alt-text image

{{note
If there are 2 or more consecutive spaces in the alt-text for an image, everything breaks. It also breaks if the alt-text either starts with or ends with a space.
}}

1. ![ where is my image??](http://i.imgur.com/hMna6G0.png)
2. ![where  is my image??](http://i.imgur.com/hMna6G0.png)
3. ![where is my image?? ](http://i.imgur.com/hMna6G0.png)
4. ![where is my image??](http://i.imgur.com/hMna6G0.png){height=20%,width=20%}

All 4 should show. Previously, only the 4th.

Reviewer Checklist

*Reviewers, refer to this list when testing features, or suggest new items *

  • Verify new features are functional
    • Image links with any number and placement of arbitrary space work.
  • Verify old features have not broken
  • Identify opportunities for simplification and refactoring
  • Check for code legibility and appropriate comments

…line definitions.

This was failing due to both labels having the extraneous spaces cleaned up but the variable label portion of the varCallInline did not, preventing them from being matched during variable resolution.
@dbolack-ab dbolack-ab self-assigned this Jan 29, 2025
@dbolack-ab dbolack-ab added the bug We say this works but it doesn't label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug We say this works but it doesn't
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

images with alt-text with bad spaces get eaten
2 participants