Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block cloning #3512

Open
5e-Cleric opened this issue Jun 4, 2024 · 5 comments · May be fixed by #3637
Open

Block cloning #3512

5e-Cleric opened this issue Jun 4, 2024 · 5 comments · May be fixed by #3637
Labels
feature P3 - low priority Obscure tweak or fix for a single user sub-epic Sub-task of an Epic

Comments

@5e-Cleric
Copy link
Member

5e-Cleric commented Jun 4, 2024

It'd be great if users could block the souece dropdown in the share page for their brews, as both a brew per brew basis or a user setting.

Ideally this would work like this:

  • If a user sets a block on a brew, the clone to new button , view source, and download stop appearing or appear disabled. It would be considered unclonable.

  • If a user with an account sets the default to all their brews as non-clonable, brew-per-brew option would not be possible, and all brews are unclonable.

I know users will still be able to get the text via dev tools, but most users would not.

@5e-Cleric 5e-Cleric added feature P3 - low priority Obscure tweak or fix for a single user sub-epic Sub-task of an Epic labels Jun 4, 2024
@Gazook89
Copy link
Collaborator

Gazook89 commented Jun 4, 2024

Philosophically, is non-source available brews something we want, or should all brews have their source available?

@5e-Cleric
Copy link
Member Author

I think it makes sense for users to prevent others from cloning their stuff and claiming it as own by the click of a single button, lol

@ericscheid
Copy link
Collaborator

So long as we don't frame the option as being total protection, because it isn't,

@5e-Cleric
Copy link
Member Author

Should be part of #1908

@G-Ambatte
Copy link
Collaborator

This is somewhat complicated... There are currently two access types, share and edit. The new Brew Locking feature I've been working on will block any attempt to access a "locked" brew via any method other than edit. However for this feature, we'd need to differentiate share based on the calling page: perhaps something like view (for /share) and source (for viewing /source, cloning to /new, and so on).
It's not impossible and probably not the most difficult feature in the world to create.


Account wide protection, however, is a bit trickier. We either need to add a check against the User's account wide settings (which, specifically, don't exist at this point in time), or come up with a way for the User to update multiple (or even all) brews at once (which also does not currently exist).
To be clear, I think both options will need to exist at some point in the near future. Account checks probably makes more sense; in that it has a much smaller potential DB impact than users mass updating their brews.

@5e-Cleric 5e-Cleric linked a pull request Aug 14, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature P3 - low priority Obscure tweak or fix for a single user sub-epic Sub-task of an Epic
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants