Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Add social links to Share Page #2067

Closed
G-Ambatte opened this issue Mar 13, 2022 · 3 comments
Closed

[UI] Add social links to Share Page #2067

G-Ambatte opened this issue Mar 13, 2022 · 3 comments
Labels
blocked Waiting on a dependency, other feature, etc., first P2 - minor feature or not urgent Minor bugs or less-popular features UI/UX User Interface, user experience

Comments

@G-Ambatte
Copy link
Collaborator

Reddit link - https://redd.it/tcynbw

As mentioned in the Reddit link, the capability to add the author's Social Links already exists. If we include a system where this is simplified, we can ensure that the social and donation links employ a style that is visually distinct from the Homebrewery UI, to reinforce that these links are not affiliated with Homebrewery and/or the development team.

@G-Ambatte G-Ambatte added blocked Waiting on a dependency, other feature, etc., first UI/UX User Interface, user experience P2 - minor feature or not urgent Minor bugs or less-popular features labels Mar 13, 2022
@G-Ambatte
Copy link
Collaborator Author

G-Ambatte commented Mar 13, 2022

I believe that the solution to this will require that the following issues are already resolved:

#1908 User Settings framework
#2049 UI Page style

Once these two are in place, it should be relatively simple to store the required data in the UserInfo framework, and allow this data to be set by the Users via a UI page.

Tagged as Blocked until these are resolved.

@5e-Cleric
Copy link
Member

These are resolved, but i am not sure why is this necessary, considering closing this issue.

@Gazook89
Copy link
Collaborator

Yeah, I think we can close this (and I will do so). I don't see this as being a priority, nor is the lack of it causing any big problems. Users can add whatever links they want in their brews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Waiting on a dependency, other feature, etc., first P2 - minor feature or not urgent Minor bugs or less-popular features UI/UX User Interface, user experience
Projects
None yet
Development

No branches or pull requests

3 participants