diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 59aae5970..b9073efdf 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -39,7 +39,7 @@ jobs: - if: ${{ fromJSON(steps.tag.outputs.create) }} name: Pack # https://learn.microsoft.com/en-us/nuget/create-packages/symbol-packages-snupkg - run: dotnet pack -c Release -o dist -p:IncludeSymbols=true -p:SymbolPackageFormat=snupkg + run: dotnet pack -c Release -o dist -p:IncludeSymbols=true -p:SymbolPackageFormat=snupkg -p:ContinuousIntegrationBuild=true - if: ${{ fromJSON(steps.tag.outputs.create) }} name: Push diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index cc5a2963f..f3720fec7 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -140,12 +140,12 @@ jobs: run: | Invoke-WebRequest https://download.jetbrains.com/resharper/JetBrains.dotMemoryUnit.3.2.20220510.zip -OutFile dotMemoryUnit.zip Expand-Archive dotMemoryUnit.zip - nuget install NUnit.ConsoleRunner -version 3.16.3 $current_path = (Get-Item .).FullName echo "$current_path\dotMemoryUnit" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append + dotnet tool install --global NUnit.ConsoleRunner.NetCore - name: Build - run: dotnet build -c Debug + run: dotnet build -c Release - - name: Memory Test - run: dotMemoryUnit .\NUnit.ConsoleRunner.3.16.3\tools\nunit3-console.exe --propagate-exit-code -- .\tests\NATS.Client.Core.MemoryTests\bin\Debug\net6.0\NATS.Client.Core.MemoryTests.dll + - name: Memory Test (net6.0) + run: dotMemoryUnit $env:userprofile\.dotnet\tools\nunit.exe --propagate-exit-code -- .\tests\NATS.Client.Core.MemoryTests\bin\Release\net6.0\NATS.Client.Core.MemoryTests.dll diff --git a/Directory.Build.props b/Directory.Build.props index 6dad22341..c196e8d9e 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -5,6 +5,9 @@ $(NoWarn);CS1591;SA0001 true $(MSBuildThisFileDirectory)opensource.snk + + + false diff --git a/tests/NATS.Client.Core.MemoryTests/NATS.Client.Core.MemoryTests.csproj b/tests/NATS.Client.Core.MemoryTests/NATS.Client.Core.MemoryTests.csproj index 087160d7b..177ee3659 100644 --- a/tests/NATS.Client.Core.MemoryTests/NATS.Client.Core.MemoryTests.csproj +++ b/tests/NATS.Client.Core.MemoryTests/NATS.Client.Core.MemoryTests.csproj @@ -7,6 +7,9 @@ false true + + + false diff --git a/tests/NATS.Client.Core.MemoryTests/NatsConsumeTests.cs b/tests/NATS.Client.Core.MemoryTests/NatsConsumeTests.cs index bb9c203c4..b1dc35ad0 100644 --- a/tests/NATS.Client.Core.MemoryTests/NatsConsumeTests.cs +++ b/tests/NATS.Client.Core.MemoryTests/NatsConsumeTests.cs @@ -12,16 +12,13 @@ public class NatsConsumeTests [Test] public void Subscription_should_not_be_collected_when_in_consume_async_enumerator() { - Console.WriteLine(">>> STARTING: MEM CONSUMER TEST"); - - var server = NatsServer.StartJSWithTrace(new TestTextWriterOutput(Console.Out)); + var server = NatsServer.StartJS(); try { var nats = server.CreateClientConnection(new NatsOpts { RequestTimeout = TimeSpan.FromSeconds(10) }); var js = new NatsJSContext(nats); - var rtt = nats.PingAsync().AsTask().GetAwaiter().GetResult(); - Console.WriteLine($">>> RTT: {rtt.TotalMilliseconds}ms"); + nats.PingAsync().AsTask().GetAwaiter().GetResult(); var sync = new TaskCompletionSource(); @@ -107,16 +104,13 @@ public void Subscription_should_not_be_collected_when_in_consume_async_enumerato [Test] public void Subscription_should_not_be_collected_when_in_ordered_consume_async_enumerator() { - Console.WriteLine(">>> STARTING: MEM ORDERED CONSUMER TEST"); - - var server = NatsServer.StartJSWithTrace(new TestTextWriterOutput(Console.Out)); + var server = NatsServer.StartJS(); try { var nats = server.CreateClientConnection(new NatsOpts { RequestTimeout = TimeSpan.FromSeconds(10) }); var js = new NatsJSContext(nats); - var rtt = nats.PingAsync().AsTask().GetAwaiter().GetResult(); - Console.WriteLine($">>> RTT: {rtt.TotalMilliseconds}ms"); + nats.PingAsync().AsTask().GetAwaiter().GetResult(); var sync = new TaskCompletionSource();