Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android][Slider]: Color properties #48

Open
ADjenkov opened this issue Sep 9, 2019 · 1 comment
Open

[Android][Slider]: Color properties #48

ADjenkov opened this issue Sep 9, 2019 · 1 comment

Comments

@ADjenkov
Copy link
Collaborator

ADjenkov commented Sep 9, 2019

Question 1: rippleColor=”red” on <mds:Slider> just sets thumbColorProperty with no rippleEffect. Is this expected?
image

Question 2: color=”red” paints everything (thumb, trackbar..). Is this expected?
image
When color=”red” is set you cannot change thumb circle color even if thumbColor=”blue” is set for Android. On iOS thumbColor="blue" is respected as expected.

@farfromrefug
Copy link
Member

@ADjenkov
Question 1 : I cant remember why i did that. Think it was because of iOS implementation. Will fix it however:

  • no way to change ripple color on android for now.
  • not working on iOS :s

Question 2: Yes intended. This property is not used in {N} default slider but i needed it to easily tint a slider. Seems like the right property to me

Question 3: seems to be an issue in android Seekbar, Calling setThumbTintList after setProgressTintList does not work. Will look into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants