Skip to content

Commit 50d724a

Browse files
committed
fix(ios): ensure _bottomSheetClosed is called as soon as possible
1 parent 8fde3ca commit 50d724a

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

src/bottomsheet/bottomsheet-common.ts

+1
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,7 @@ export abstract class ViewWithBottomSheetBase extends View {
135135
this._bottomSheetContext.closeCallback = null;
136136
}
137137
const whenClosedCallback = () => {
138+
this._bottomSheetClosed();
138139
if (typeof options.closeCallback === 'function') {
139140
options.closeCallback.apply(undefined, originalArgs);
140141
}

src/bottomsheet/bottomsheet.ios.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -465,7 +465,7 @@ export class ViewWithBottomSheet extends ViewWithBottomSheetBase {
465465
}
466466

467467
_bottomSheetClosed() {
468-
// super already closed we are just a mixin
468+
// super already called we are just a mixin
469469

470470
if (this.bottomSheetController) {
471471
this.bottomSheetController.delegate = null;

0 commit comments

Comments
 (0)