Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DF-832-Prototype/search filters accordion #1434

Closed

Conversation

JohnHeeryTNA
Copy link
Collaborator

Ticket URL: https://national-archives.atlassian.net/browse/DF-832

About these changes

Integrating the GDS accordion component into search filters

How to check these changes

Performa search, open and close the filter accordion, apply filters to confirm functionality. Test across viewports.

Before assigning to reviewer, please make sure you have

  • Checked things thoroughly before handing over to reviewer
  • Checked PR title starts with ticket number as per project conventions to help us keep track of changes
  • Ensured that PR includes only commits relevant to the ticket
  • Waited for all CI jobs to pass before requesting a review
  • Added/updated tests and documentation where relevant

Merging PR guidance

Follow docs\developer-guide\contributing.md

Deployment guidance

Follow docs\infra\environments.md

JohnHeeryTNA and others added 30 commits October 24, 2023 14:24
@ahosgood ahosgood added the finding Work relating to the Finding team label Nov 17, 2023
@ahosgood
Copy link
Member

Closing this as the work will be re-done in the new ds-search repository

@ahosgood ahosgood closed this Sep 17, 2024
@ahosgood ahosgood deleted the prototype/search-mobile-accordian-form-integrate branch January 6, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
finding Work relating to the Finding team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants