Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails with Clojure 1.10.1 #23

Open
robbieh opened this issue May 4, 2020 · 4 comments
Open

Fails with Clojure 1.10.1 #23

robbieh opened this issue May 4, 2020 · 4 comments

Comments

@robbieh
Copy link

robbieh commented May 4, 2020

If I update my Clojure dependency from 1.6.0 to 1.10.1, clj-tagsoup no longer works.

From the repl, I get the following when trying to :require tagsoup:

CompilerException java.lang.Exception: namespace 'clojure.data.xml' not found, compiling:(pl/danieljanus/tagsoup.clj:1:1)

From my test cases, I get:

In: [1 0] val: {:keys (attrs)} fails spec: :clojure.core.specs.alpha/arg-list at: [:args :bs :arity-n :bodies :args] predicate: vector?
In: [1 0] val: ({:keys (attrs)} writer) fails spec: :clojure.core.specs.alpha/arg-list at: [:args :bs :arity-1 :args] predicate: (cat :args (* :clojure.core.specs.alpha/binding-form) :varargs (? (cat :amp #{(quote &)} :form :clojure.core.specs.alpha/
binding-form))),  Extra input                           
 #:clojure.spec.alpha{:problems ({:path [:args :bs :arity-1 :args], :reason "Extra input", :pred (clojure.spec.alpha/cat :args (clojure.spec.alpha/* :clojure.core.specs.alpha/binding-form) :varargs (clojure.spec.alpha/? (clojure.spec.alpha/cat :amp #
{(quote &)} :form :clojure.core.specs.alpha/binding-form))), :val ({:keys (attrs)} writer), :via [:clojure.core.specs.alpha/defn-args :clojure.core.specs.alpha/args+body :clojure.core.specs.alpha/arg-list :clojure.core.specs.alpha/arg-list], :in [1 0
]} {:path [:args :bs :arity-n :bodies :args], :pred clojure.core/vector?, :val {:keys (attrs)}, :via [:clojure.core.specs.alpha/defn-args :clojure.core.specs.alpha/args+body :clojure.core.specs.alpha/args+body :clojure.core.specs.alpha/args+body :clo
jure.core.specs.alpha/arg-list :clojure.core.specs.alpha/arg-list], :in [1 0]}), :spec #object[clojure.spec.alpha$regex_spec_impl$reify__2436 0x79a1728c "clojure.spec.alpha$regex_spec_impl$reify__2436@79a1728c"], :value (write-attributes [{:keys (att
rs)} writer] (doseq [[k v] attrs] (if (namespace k) (.writeAttribute writer (str (namespace k)) (name k) (str v)) (.writeAttribute writer (name k) (str v))))), :args (write-attributes [{:keys (attrs)} writer] (doseq [[k v] attrs] (if (namespace k) (.
writeAttribute writer (str (namespace k)) (name k) (str v)) (.writeAttribute writer (name k) (str v)))))}, compiling:(clojure/data/xml.clj:30:1)

test.txt

@nathell
Copy link
Owner

nathell commented May 4, 2020

Thanks for the report! A PR that should fix this has been recently merged and a clj-tagsoup 0.3.1 should be out soon.

@robbieh
Copy link
Author

robbieh commented May 4, 2020

Sounds good. Thank you!

@l-acs
Copy link

l-acs commented Oct 21, 2020

Hi there, I'm getting the same issue. Are there still plans for a 0.3.1? Thank you!

@lfilatova
Copy link

Workaround here #22 (comment)

:dependencies [[org.clojure/data.xml "0.0.8"]
               [clj-tagsoup "0.3.0" :exclusions [org.clojure/data.xml]]]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants