diff --git a/README.md b/README.md index 7875434..7b3c927 100644 --- a/README.md +++ b/README.md @@ -1,11 +1,15 @@ # Duckup -Just install the latest version of duckdb in my `~/.local/bin`. Designed for linux, since duckdb CLI can't yet be installed via a linux package manager. +Since duckdb CLI can't yet be installed via a linux package manager, this will install the latest version of the duckdb CLI on your computer. Default location is `~/.local/bin/`, but you can choose your own location with the `--folder_path` option. -Currently very dangerous: it just sticks it in `~/.local/bin/duckdb`, overwriting anything that might have been there. Use with great caution. +Use with caution, it will overwrite an existing binary. + +## Goals + +It would be nice to eventually make this tool work like the wonderful [`rustup`](https://github.com/rust-lang/rustup) and [`juliaup`](https://github.com/JuliaLang/juliaup) tools. However, there is a very long way to go to reach that. ## Use 1. Have the [rust toolchain](https://www.rust-lang.org/tools/install) installed 1. Run `cargo install duckup` 1. Run `duckup` for help message -1. Run `duckup update` to install the latest version of the duckdb CLI into `~/.local/bin` +1. Run `duckup update` to install the latest version of the duckdb CLI into `~/.local/bin`. Run `duckup update --folder_path /path/to/desired/location/` to install to a location of your choice. diff --git a/src/main.rs b/src/main.rs index 217819c..aaa819a 100644 --- a/src/main.rs +++ b/src/main.rs @@ -300,13 +300,6 @@ fn update(dest_folder: &Path) -> Result<()> { perms.set_mode(0o755); std::fs::set_permissions(&executable_file, perms).context("failed to set permissions")?; println!("Successfully set permissions"); - // std::process::Command::new("chmod") - // .args([ - // "+x", - // dest_folder.to_str().expect("Failed to convert to &str"), - // ]) - // .status() - // .expect("Unable to set permissions"); Ok(()) }