disableAfterRate cannot enter a lower rating

[kevinvanryck]

When setting disableAfterRate to false, and rating 5/5, then trying to rate 3/5, the rating is set in the callback, but the stars shown on the screen will stay on 5/5, even though the rating changed to 3/5.

This can be tested on the demo page, on the "On hover event" demo, since this one has the disableAfterRate flag disabled
https://nashio.github.io/star-rating-svg/demo/

Can be tested also with this snippet:

$('.rating').starRating('setRating', 5);
$('.rating').starRating('setRating', 3); // does not work
$('.rating').starRating('setRating', 2); // does not work

[gabidabet]

yeah it work internally but not visually, comment this code and you will be fine :
if (stateClass === 'rated' && endIndex > -1) { // limit to painting only to rated stars, and specific case for half star if (index <= Math.ceil(endIndex) || (index < 1 && endIndex < 0)) { $polygonLeft.attr('style', 'fill:'+ratedColor); } if (index <= endIndex) { $polygonRight.attr('style', 'fill:'+ratedColor); } }

[janones]

Or alter method paintStars() and add these two "Elses"

if (index <= Math.ceil(endIndex) || (index < 1 && endIndex < 0)) { $polygonLeft.attr('style', 'fill:'+ratedColor); } else { //lets you deselect stars $polygonLeft.attr('style', 'stroke-opacity: 0;'); }
if (index <= endIndex) { $polygonRight.attr('style', 'fill:'+ratedColor); } else { //lets you deselect stars $polygonRight.attr('style', 'stroke-opacity: 0;'); }

[matuskm]

hello,

where should i put it ?

[janones]

the paintStars() method looks like this after the change:

lines with corrections 192 and 200

[nibblebits]

Don't forget to set disableAfterRate to false if your still having this problem after making these changes.