Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SemGetInfo partial success cases #1440

Open
skliper opened this issue Jan 5, 2024 · 0 comments · May be fixed by #1480
Open

SemGetInfo partial success cases #1440

skliper opened this issue Jan 5, 2024 · 0 comments · May be fixed by #1480

Comments

@skliper
Copy link
Contributor

skliper commented Jan 5, 2024

Is your feature request related to a problem? Please describe.
OS_BinSemGetInfo and OS_CountSemGetInfo fill in the following structures:

osal/src/os/inc/osapi-binsem.h

Lines 38 to 44 in 1a8823f

/** @brief OSAL binary semaphore properties */
typedef struct
{
char name[OS_MAX_API_NAME];
osal_id_t creator;
int32 value;
} OS_bin_sem_prop_t;

osal/src/os/inc/osapi-countsem.h

Lines 32 to 37 in 1a8823f

typedef struct
{
char name[OS_MAX_API_NAME];
osal_id_t creator;
int32 value;
} OS_count_sem_prop_t;

Where name and creator may be valid but not all implementations fill in value (ex. RTEMS):

osal/src/os/rtems/src/os-impl-binsem.c

Lines 275 to 279 in 1a8823f

int32 OS_BinSemGetInfo_Impl(const OS_object_token_t *token, OS_bin_sem_prop_t *bin_prop)
{
/* RTEMS has no API for obtaining the current value of a semaphore */
return OS_SUCCESS;
}

Note the following PR changes the RTEMS return to OS_ERR_NOT_IMPLEMENTED

Describe the solution you'd like
Consider splitting the API into 2 or 3. GetValue could return value or unimplemented error. GetName/GetCreator or similar could return the other two.

Describe alternatives you've considered
None

Additional context
Partial success API's are not user friendly and should be avoided.

Requester Info
Jacob Hageman - NASA/GSFC
thnkslprpt added a commit to thnkslprpt/osal that referenced this issue Oct 6, 2024
@thnkslprpt
Fix nasa#1440, Split up BinSemGetInfo() to avoid partial success returns
74064dc
@thnkslprpt thnkslprpt linked a pull request Oct 6, 2024 that will close this issue
Open
2 tasks
thnkslprpt added a commit to thnkslprpt/osal that referenced this issue Oct 8, 2024
@thnkslprpt
Fix nasa#1440, Split up BinSemGetInfo() to avoid partial success returns
0e2d950
thnkslprpt added a commit to thnkslprpt/osal that referenced this issue Oct 8, 2024
@thnkslprpt
Fix nasa#1440, Split up BinSemGetInfo() to avoid partial success returns
6459099
thnkslprpt added a commit to thnkslprpt/osal that referenced this issue Oct 10, 2024
@thnkslprpt
Fix nasa#1440, Split up BinSemGetInfo() to avoid partial success returns
f8855ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #1440, Split up BinSemGetInfo() to avoid partial success returns thnkslprpt/osal
1 participant
@skliper