Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new check to clearData that enables data clearing on overlay plots. #7961

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mudinthewater
Copy link

@mudinthewater mudinthewater commented Dec 13, 2024

Closes

Describe your changes:

Closes #7947

This change adds a new case to the existing 3 logic scenarios in the ClearData function (new case in bold):

  • if no domain object (clear data)
  • else if the object requesting the clear is the same as the currently plotting object (clear data)
  • else if the object requesting the clear's composition contains the currently plotting object (clear data)
  • else if the object requesting the clear is within the composition of the currently plotting object (clear data)

I maintain that the 3rd case, compositionPathContainsId may have originally been intended to capture the 4th case, but I don't want to break someone else's work so it is safer to just cover the currently missing 4th case.

To test this change, you'll have to do the following:

  1. Add 'openmct.objectViews.emit('clearData',domainObject);'
    to the TelemetryMeanProvider.
  2. Create a new mean object and select it in the tree.
  3. Put the mean object into an overlay plot and zoom out. The mean should be re-calculated and re-plotted on every zoom level.

Note: This is much easier to test with a server responding to telemetry requests as opposed to using sine wave generators.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 57.26%. Comparing base (5be103e) to head (aca4727).

Files with missing lines Patch % Lines
src/plugins/plot/MctPlot.vue 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7961      +/-   ##
==========================================
- Coverage   57.57%   57.26%   -0.32%     
==========================================
  Files         678      678              
  Lines       27428    27434       +6     
  Branches     2691     2693       +2     
==========================================
- Hits        15793    15711      -82     
- Misses      11294    11382      +88     
  Partials      341      341              
Flag Coverage Δ
e2e-ci 62.82% <ø> (ø)
e2e-full 23.65% <ø> (-18.32%) ⬇️
unit 49.33% <0.00%> (-0.04%) ⬇️
Files with missing lines Coverage Δ
src/plugins/plot/MctPlot.vue 36.89% <0.00%> (-0.31%) ⬇️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5be103e...aca4727. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClearData Emit action is missing case where the ClearData emit originates from within an object.
1 participant