-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Conditionals] Increase performance, switch to TelemetryCollections #7841
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7841 +/- ##
==========================================
- Coverage 58.88% 58.78% -0.11%
==========================================
Files 675 675
Lines 27284 27277 -7
Branches 2671 2671
==========================================
- Hits 16066 16034 -32
- Misses 11171 11195 +24
- Partials 47 48 +1
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! and nice job cleaning up that wild style code. I have a couple of suggestions where we can further improve performance, and I have some other suggestions for readability improvements.
Also this needs test(s) 😛
btw this test is failing in ci: [chrome] › functional/plugins/styling/stackedPlotStyling.e2e.spec.js:159:3 › Stacked Plot styling › styling a child object of the flexible layout properly applies that style to only that child
…sa/openmct into conditional-style-performance mergin master
@ozyx was this change still under review? It touches some code in a file that I'm also working on (ConditionManager.js), so I want to get it merged into my branch when it's ready |
It just needs a test. So you can probably safely rebase onto this branch and then rebase onto master once you're ready to open a PR |
awesome, thank you! |
Closes #7840
Believe this may be the issue reported in: VIPERGC-550
Describe your changes:
Add some performance enhancements to conditional styling:
requestAnimationFrame
Switched to TelemetryCollections from older and separate
subscribe
and historicalrequest
. This prevents situations where different telemetry was being evaluated in a condition vs the telemetry itself in the item being styled with the condition. This also just brings conditions in line with the rest of our code that uses TelemetryCollections.All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist