-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bar graphs should only get latest historical datum #7811
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7811 +/- ##
==========================================
+ Coverage 56.14% 58.68% +2.54%
==========================================
Files 674 674
Lines 27283 27283
Branches 2669 2669
==========================================
+ Hits 15317 16012 +695
+ Misses 11629 11223 -406
+ Partials 337 48 -289
... and 159 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple minor comments and a question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running the e2e test 10x in a docker env that matches our CI environment demonstrates inherent flakiness due to the lack of determinate waits:
I think we should move this test to the openmct-yamcs
side so we can test it against real network requests in addition to having deterministic wait conditions via waitForRequest()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that we have tests in the openmct-yamcs PR, let's remove the tests from this PR
Closes #7781
Describe your changes:
Since bar graphs only need the latest telemetry, set the size of historical request to 1
All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist