Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bar charts only need to request one historical value because they can only show one spectrum at a time. #7781

Closed
akhenry opened this issue Jul 15, 2024 · 1 comment · Fixed by #7811
Labels
performance impacts or improves performance severity:critical type:enhancement verified Tested or intentionally closed
Milestone

Comments

@akhenry
Copy link
Contributor

akhenry commented Jul 15, 2024

Summary

Our bar chart view issues an historical request on load in order to populate the chart with the latest data. Because of the nature of bar charts, we only show data for the latest timestamp, so there is no value in retrieving anything older.

We should add "size=1" to our default request options in BarGraphView.vue.

This is tickling a Yamcs bug which is causing major performance issues, so I am assigning it a higher priority than I normally would for what is otherwise an optimization.

@akhenry
Copy link
Contributor Author

akhenry commented Oct 16, 2024

Verified fixed. Switched to fixed mode in a chart object, refreshed the view, confirmed that the request to the parameter archive included limit=1

@akhenry akhenry added the verified Tested or intentionally closed label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance impacts or improves performance severity:critical type:enhancement verified Tested or intentionally closed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant