-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request for contributions: Ibis support #1886
Comments
I can have a go at it. I have my own Narwhals Ibis implementation built out so will just need to update and make sure it meets any recent changes/patterns in Narwhals. |
amazing, thanks @rwhitten577 ! |
Hey @MarcoGorelli, I'm starting work on this and saw Ibis just released 10.0 with a bunch of new breaking API changes. Narwhals has Ibis >= 6.0 which is pretty far behind. Think we can target Ibis lazy support to >= 9.0 to reduce the scope of this? |
sure sounds good, we can always loosen later |
@rwhitten577 I'm in the middle of a large refactor, if you wait say 1 week then it should become significantly easier to support ibis |
No worries @MarcoGorelli. I have a good start in #2000, just working through getting all tests to pass. I'll pause here for now until your refactor is in. |
I'm quite confident about how we're supporting PySpark DuckDB, and I think it's time to support Ibis too.
I think that it can probably mostly be supported by just copy-and-pasting what's in
narwhals/_duckdb
and making some API adjustments. I don't think any major refactor or anything like that would be required.Anyone fancy trying this? If so, contributions would be welcome! You can start by reading the contributing guide, and reaching out to us here or on Discord if anything trips you up
The text was updated successfully, but these errors were encountered: