Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for contributions: Ibis support #1886

Open
MarcoGorelli opened this issue Jan 28, 2025 · 6 comments · May be fixed by #2000
Open

Request for contributions: Ibis support #1886

MarcoGorelli opened this issue Jan 28, 2025 · 6 comments · May be fixed by #2000
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@MarcoGorelli
Copy link
Member

I'm quite confident about how we're supporting PySpark DuckDB, and I think it's time to support Ibis too.

I think that it can probably mostly be supported by just copy-and-pasting what's in narwhals/_duckdb and making some API adjustments. I don't think any major refactor or anything like that would be required.

Anyone fancy trying this? If so, contributions would be welcome! You can start by reading the contributing guide, and reaching out to us here or on Discord if anything trips you up

@MarcoGorelli MarcoGorelli added the enhancement New feature or request label Jan 28, 2025
@FBruzzesi FBruzzesi added the help wanted Extra attention is needed label Jan 29, 2025
@rwhitten577
Copy link

I can have a go at it. I have my own Narwhals Ibis implementation built out so will just need to update and make sure it meets any recent changes/patterns in Narwhals.

@MarcoGorelli
Copy link
Member Author

amazing, thanks @rwhitten577 !

@rwhitten577
Copy link

Hey @MarcoGorelli, I'm starting work on this and saw Ibis just released 10.0 with a bunch of new breaking API changes. Narwhals has Ibis >= 6.0 which is pretty far behind. Think we can target Ibis lazy support to >= 9.0 to reduce the scope of this?

@MarcoGorelli
Copy link
Member Author

sure sounds good, we can always loosen later

@MarcoGorelli
Copy link
Member Author

@rwhitten577 I'm in the middle of a large refactor, if you wait say 1 week then it should become significantly easier to support ibis

@rwhitten577 rwhitten577 linked a pull request Feb 12, 2025 that will close this issue
10 tasks
@rwhitten577
Copy link

No worries @MarcoGorelli. I have a good start in #2000, just working through getting all tests to pass. I'll pause here for now until your refactor is in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants