Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Missing license classifier #1750

Closed
nickwww opened this issue Jan 7, 2025 · 3 comments
Closed

[Bug]: Missing license classifier #1750

nickwww opened this issue Jan 7, 2025 · 3 comments

Comments

@nickwww
Copy link

nickwww commented Jan 7, 2025

Describe the bug

Version 1.19.1 dropped the metadata classifier for the license in pyproject.toml. We found out when our CI stopped working because we were testing against an allow list with pip-licenses.

Steps or code to reproduce the bug

Install narwhals and pip-licenses. Run pip-licenses and check the output.

Expected results

Only a short license classifier should be returned when using pip-licenses.

Actual results

The latest version outputs the full license text instead of a short classifier.

Please run narwhals.show_version() and enter the output below.

Used version 1.19.0 and 1.19.1 for comparison.

Relevant log output

No response

@MarcoGorelli
Copy link
Member

thanks for the report

we have it here:

license = {file = "LICENSE.md"}

and the license:

https://github.com/narwhals-dev/narwhals/blob/320d6bc72a000f2302f48f00ae4a44ac22101c28/LICENSE.md

is there anything we need to change?

@MarcoGorelli
Copy link
Member

ok i see the issue - patch release coming up, thanks for the report!

@MarcoGorelli
Copy link
Member

closed by #1751

@nickwww if you install the latest release it should be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants