Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken jinja formatting in manifest schema (affects "Manifest Reference" docs page) #347

Open
GenevieveBuckley opened this issue May 8, 2024 · 0 comments

Comments

@GenevieveBuckley
Copy link
Contributor

It looks like there is broken formatting in the "Fields" table from the napari.yaml manifest reference documentation page. See https://napari.org/stable/plugins/manifest.html#fields

You can see that the table formatting breaks at the 'icons' row, probably because the jinja template tries to use dot points in the description. Then the following five fields are not given their own row in the table, which makes it easy to overlook them (it appears like a confusing description for the icon field):

  • categories
  • schema_version
  • on_activate
  • on_deactivate
  • contributions

This is the file that needs to be edited: https://github.com/napari/npe2/blob/main/src/npe2/manifest/schema.py

Here is a screenshot showing the formatting failure:
Screenshot 2024-05-08 at 6 18 46 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant