Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a status bar: Improvements to the way extra information is given when a install/uninstall action is done (WarnPopup alternatives) #69

Open
dalthviz opened this issue Jul 10, 2024 · 10 comments · May be fixed by #98
Assignees
Labels

Comments

@dalthviz
Copy link
Member

Ended up pushing a commit making the popup appear besides the installed label counter text, so things are looking something like the following:

Sorry for the bikeshedding here, but in my eyes this pop up in general is a bit weird. It's supposed to give information about a the plugin dialog. This small box looks more like a tooltip that, if anything, should appear next to the button that triggered the action.

I feel that a message bar like this is more appropriate. It would be placed either at the top of the dialog box, or at the bottom. It should cover the full width of the dialog too.

image

And maybe this is useful for some other notifications. But speaking of that... if this is too much work or you see it as unnecessary... why not push a message to the napari notification system?

Originally posted by @jaimergp in #68 (comment)

@dalthviz dalthviz changed the title Improvements to the way extra information is given when a install/uninstall actions is done (WarnPopup alternarives) Improvements to the way extra information is given when a install/uninstall action is done (WarnPopup alternarives) Jul 10, 2024
@dalthviz dalthviz changed the title Improvements to the way extra information is given when a install/uninstall action is done (WarnPopup alternarives) Improvements to the way extra information is given when a install/uninstall action is done (WarnPopup alternatives) Jul 10, 2024
@dalthviz dalthviz added the UX/UI label Jul 10, 2024
@dalthviz
Copy link
Member Author

Some other related comments: #68 (comment)

@goanpeca
Copy link
Contributor

I am not sure I recall the design decision that went into doing this as an extra popup dialog on top of yet another modal dialog.

The napari notification system would be a good option, if the napari plugin manager was a panel or tab inside the main windows. This is something a suggested a long time ago, since it was not favored at the time, and we continue being an extra dialog on top of the main app, I would suggest we just use the bottomg of the dialog for messaging, since that is close to the show status button where we display fine grained information about the processes.

@goanpeca goanpeca self-assigned this Jul 19, 2024
@psobolewskiPhD
Copy link
Member

psobolewskiPhD commented Jul 20, 2024

I don't see an issue with the napari notification.
User installs plugin, let's say they don't notice anything, but then closes installer -- there's the notification. As long as it's persistent and doesn't auto-close anyways?

Edit: bah, show_warning does auto-hide eventually. <30 s.
@Czaki is there a way to persist until dismissed? different warning maybe? Am I missing something?

@psobolewskiPhD
Copy link
Member

psobolewskiPhD commented Jul 20, 2024

Looks like right now all things use 4000 ms.
I think warnings/errors persisting is reasonable? I'll make a napari PR and we can see what folks think.

Edit: PR to make warnings/errors persistent:
napari/napari#7114

@goanpeca
Copy link
Contributor

I would actually like to see persistence in terms of having a history. I do not mind warnings hiding after a "reasonable" time (right now it feels too short BTW), if I have a history and I can go there and checked what happened with more detail

Screenshot 2024-07-20 at 1 40 51 PM

@psobolewskiPhD
Copy link
Member

That would be nice I think, but but if the notification disappears before you know it was there -- because it was obscured by the plugin installer, then how would you know to check?

@goanpeca
Copy link
Contributor

Good point!, I guess both things might be needed in the long run :) so that during the napari session, the user can check all the notifications that came about

@psobolewskiPhD
Copy link
Member

I do like the idea of the "bell" icon and status indicator though!

@goanpeca
Copy link
Contributor

Is there an issue on napari @psobolewskiPhD , maybe we could open one in order to make the notifications manager a bit more sophisticated :)

@jaimergp
Copy link
Contributor

Gonzalo and I were talking about this and might make more sense to have a more useful "status bar" and rearrange some of the UI elements to make enough space for it. I'll rename this issue accordingly.

@jaimergp jaimergp changed the title Improvements to the way extra information is given when a install/uninstall action is done (WarnPopup alternatives) Add a status bar: Improvements to the way extra information is given when a install/uninstall action is done (WarnPopup alternatives) Jul 29, 2024
@goanpeca goanpeca linked a pull request Aug 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants