-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a release action #497
base: main
Are you sure you want to change the base?
Add a release action #497
Conversation
This action will build and deploy docs for a new release, copying the built docs artifacts to both the dev and the {version} folders in napari.github.io. It will also update the stable symlink to point to the new version folder. This action will be triggered by a new release tag pushed to the repo or by manually trigerring the action with an input specifying the new version (any input different from the default dev will trigger the action.)
I am creating this as a draft, since there will need to be at least some docs written around this strategy, and I was hoping to get some feedback before we commit to it. |
external_repository: napari/napari.github.io | ||
publish_dir: ./html | ||
publish_branch: gh-pages | ||
destination_dir: ${{ github.event.inputs.target_directory || github.event.release.tag_name }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could potentially create a wrong folder if the wrong version string is passed as input to the action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how to validate this entry :(
I think this makes sense to me and would make releases easier--they're happening more frequently now, so it's worth it! |
dfb87f5
to
1ee986a
Compare
1ee986a
to
a9e9297
Compare
This is ready for another look, thanks all! |
References and relevant issues
Addresses #490
Closes #486
Depends on napari/napari.github.io#417
Description
This action will build and deploy docs for a new release, copying the built docs artifacts to both the dev and the {version} folders in napari.github.io. It will also update the stable symlink to point to the new version folder.
This action will be triggered by a new release tag pushed to the repo or by manually trigerring the action with an input specifying the new version (any input different from the default dev will trigger the action.)