Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

umi_sats.py issues #18

Open
cfblaeb opened this issue Mar 25, 2022 · 0 comments
Open

umi_sats.py issues #18

cfblaeb opened this issue Mar 25, 2022 · 0 comments

Comments

@cfblaeb
Copy link
Contributor

cfblaeb commented Mar 25, 2022

umi_sats.py is maybe useful, but a bit unfinished and unmentioned.
Its only used in the Makefile, which is also never mentioned nor used.

Should it be named umi_stats.py?
The command line arguments, -m, -M, are not required, but script will give an error if they are not provided because they have no default. (Line 220 and 221)
Function cluster_read_hist, line 198 and 199, draws a vertical line to indicate "Min cluster size" and "Max cluster size", but doesnt used the commandline provided values, but rather the "default" 20, 60.
Line 200 also, somewhat arbritrarily sets xlim to 200.

if -f is not set, then cluster_read_hist is never run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant