Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dorado basecaller crashes when alias in samplesheet.csv contains a trailing whitespace #1009

Open
sklages opened this issue Sep 2, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@sklages
Copy link

sklages commented Sep 2, 2024

dorado basecaller crashes when alias in samplesheet.csv contains a trailing whitespace:

+ dorado basecaller sup,5mCG_5hmCG <..> --sample-sheet samplesheet.csv<..>

terminate called after throwing an instance of 'std::runtime_error'
  what():  alias 'XX-Other-123 ' is not a valid string (at most 40 alphanumerical 
  characters including '-' and '_')
7559 Aborted                 (core dumped) dorado basecaller <..>

The csv parser should remove any leading/trailing whitespaces (--lenient_csv) or should give a descriptive error message (--strict_csv) .. :-)

@malton-ont malton-ont added the enhancement New feature or request label Sep 2, 2024
@malton-ont
Copy link
Collaborator

Hi @sklages,

Thanks for reporting this. We can certainly try to make this more forgiving and/or fail in a cleaner manner in a future release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants