Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix debug code that is built only in Release builds (instead of in Debug builds) #4470

Open
dsiganos opened this issue Mar 7, 2024 · 1 comment
Open

Fix debug code that is built only in Release builds (instead of in Debug builds) #4470

dsiganos opened this issue Mar 7, 2024 · 1 comment

Comments

@dsiganos
Copy link
Contributor

dsiganos commented Mar 7, 2024

In functions:

  • ledger_processor::receive_block
  • ledger_processor::open_block

the debug code is inside an ifdef NDEBUG block but it should be ifndef NDEBUG.

Also, scan the rest of the code for similar problems. They should be easy to spot.

Raising this as an issue because if I fix right now, we will get conflicts with ongoing PR merging. (#4460)
@dsiganos dsiganos changed the title Fix some debug code that is built only in Release builds (instead of in Debug builds) Fi debug code that is built only in Release builds (instead of in Debug builds) Mar 7, 2024
@dsiganos dsiganos changed the title Fi debug code that is built only in Release builds (instead of in Debug builds) Fix debug code that is built only in Release builds (instead of in Debug builds) Mar 7, 2024
@clemahieu
Copy link
Contributor

This related build error slipped in #4487.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@clemahieu @dsiganos